feat(api): create analysis runs via loopback CLI - #385
Conversation
GAP-003A / issue #166: operators can submit metric-free analysis runs through `tepp-analysis-runs create` without writing raw HTTP. Stdout stays metric-free 202 Accepted; tepp.scientific_acceptance.v1 never appears. Stacked on cancel CLI (#378). Does not duplicate GET-by-id, lifecycle POST, cancel HTTP, scientific-acceptance CLI, collection list, or cancel CLI.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hour-22 exact-head: |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT on 58a9644 (draft). Unique occupied: tepp-analysis-runs create POST /v1/analysis-runs. Stdout stays metric-free 202 Accepted. tepp.scientific_acceptance.v1 never appears. Do not duplicate GET-by-id / lifecycle / cancel / collection / retry / stored-request surfaces. Do not un-draft. Zero reviews on this SHA before this COMMENT. Never self-approve. Persistence remains GAP-003B. Do not weaken fail-closed. No Buyer language.
|
@opencode-agent repair/investigate exact-head |
Why
GAP-003A / issue #166 still required operators to write raw HTTP/1.1 after create POST. Operators cannot submit metric-free analysis runs from a client without guessing framing. Create CLI stdout stays metric-free
202 Accepted.tepp.scientific_acceptance.v1never appears.Live slices that this PR does not duplicate:
analysis_enginescientific-acceptance librarytepp-analysis-run)listc891d46a57c03e71f1ca44150a00a9d71aa2f2a9)What
Tenth GAP-003A slice stacked on #378 over collection CLI
#371/ collection GET#368/ cancel HTTP#361/ protected main1bc02f580cf48e1d39da239f0e818453437c31c3:tepp-analysis-runs createclient ofPOST /v1/analysis-runsrun_id,run_state=accepted,idempotency_keytepp.scientific_acceptance.v1never prints--idempotency-key--run-id, metric stdin, and unknown verbs fail closedNot an ADR 0014 scientific claim. Not persistence. Not GET-by-id. Not lifecycle POST. Not cancel HTTP. Not scientific-acceptance CLI. Not collection list. Not cancel CLI.
Verification
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --libcargo test -p tepp_api --test analysis_run_create_cli_contractRUSTDOCFLAGS='-D warnings' cargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pyExact head:
58a9644105044edd573eb4d314db926d4576b40cDo not merge without two independent APPROVE reviews on this exact head and current Checks. Author COMMENTED is not independent APPROVE.